Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through
From: Gustavo A. R. Silva
Date: Sat Aug 04 2018 - 22:02:32 EST
On 07/22/2018 05:17 PM, Sebastian Reichel wrote:
> On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote:
>> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote:
>>> It seems that a *break* is missing in order to avoid a fall-through.
>>> Otherwise, the calculation of *data* makes no sense.
>>> Addresses-Coverity-ID: 1271172 ("Missing break in switch")
>>> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>>> drivers/power/supply/max77693_charger.c | 1 +
>>> 1 file changed, 1 insertion(+)
>> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Thanks, queued to power-supply's fixes branch.
I think this should be tagged for stable.