Re: [PATCH bpf-next 12/13] docs: net: Fix various minor typos

From: Tobin C. Harding
Date: Sun Aug 05 2018 - 20:23:21 EST


On Fri, Aug 03, 2018 at 10:41:12AM +0200, Daniel Borkmann wrote:
> On 08/01/2018 07:09 AM, Tobin C. Harding wrote:
> > There are a few minor typos and grammatical issues. We should however
> > try to keep the current flavour of the document.
> >
> > Fix typos and grammar if glaringly required.
> >
> > Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
>
> Overall looks good, just some minor nits:
>
> > Documentation/networking/filter.rst | 65 +++++++++++++++--------------
> > 1 file changed, 33 insertions(+), 32 deletions(-)
> >
> > diff --git a/Documentation/networking/filter.rst b/Documentation/networking/filter.rst
> > index 99dfa74fc4f7..b989a6c882b8 100644
> > --- a/Documentation/networking/filter.rst
> > +++ b/Documentation/networking/filter.rst
> > @@ -32,10 +32,10 @@ removing the old one and placing your new one in its place, assuming your
> > filter has passed the checks, otherwise if it fails the old filter will
> > remain on that socket.
> >
> > -SO_LOCK_FILTER option allows to lock the filter attached to a socket. Once
> > -set, a filter cannot be removed or changed. This allows one process to
> > +SO_LOCK_FILTER option allows locking of the filter attached to a socket.
> > +Once set, a filter cannot be removed or changed. This allows one process to
> > setup a socket, attach a filter, lock it then drop privileges and be
> > -assured that the filter will be kept until the socket is closed.
> > +assured that the filter will be kept until the socket is closed.
>
> ^-- looks like extra whitespace slipped in?

Fixed in the RFC. Thanks for taking the time review.

Tobin