Re: [PATCH v3 3/4] venus: firmware: add no TZ boot and shutdown routine

From: Vikash Garodia
Date: Mon Aug 06 2018 - 04:18:56 EST

Hi Stanimir,

Thanks for your review.

On 2018-07-25 15:06, Stanimir Varbanov wrote:
Hi Vikash,

On 07/04/2018 10:06 PM, Vikash Garodia wrote:


#define VENUS_PAS_ID 9
-#define VENUS_FW_MEM_SIZE (6 * SZ_1M)
+#define VENUS_FW_MEM_SIZE (5 * SZ_1M)

This change should be subject to a separate patch.


+ writel_relaxed(reg, reg_base + WRAPPER_A9SS_SW_RESET);
+ /* Make sure reset is asserted before the mapping is removed */
+ mb();

mb() is used for compiler barrier as far as I know, isn't better to just
read the register and keep the comment?

mb() can ensure that the instructions are ordered. This is needed to ensure
reset before the mapping is removed.