Re: [PATCH] firmware: coreboot: Let OF core populate platform device

From: Sudeep Holla
Date: Mon Aug 06 2018 - 13:22:21 EST

On Mon, Aug 6, 2018 at 6:13 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> Now that the /firmware/coreboot node in DT is populated by the core DT
> platform code with commit 3aa0582fdb82 ("of: platform: populate
> /firmware/ node from of_platform_default_populate_init()") we should and
> can remove the platform device creation here. Otherwise, the
> of_platform_device_create() call will fail, the coreboot of driver won't
> be registered, and this driver will never bind. At the same time, we can
> move this driver to use platform device APIs instead of DT specific ones
> and drop the of_node handling that was presumably placed there to hold a
> reference to the DT node created during module init.

Nice cleanup.

Reviewed-by: Sudeep Holla <Sudeep.Holla@xxxxxxx>