Re: [alsa-devel] [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val

From: Pierre-Louis Bossart
Date: Mon Aug 06 2018 - 16:01:42 EST



Good to hear, applied the patch now.

BTW looking at the structures in intel_hdmi_lpe_audio.h, the field
format:3 in audio_ch_status_0 is misleading at best, it should be the
emphasis if I look at the SPDIF/AES docs. It's not used but I'll have
to relook at all this when I find some time... We should really set
the registers to mirror what the aes_bits are, not just the non_audio
and clock accuracy fields.
A fix patch is always welcome ;)
This sort of fixes is straighforward, the hard part is to locate an HDMI analyzer to double-check that the changes result in something meaningful...