Re: [PATCH v1 2/3] zinc: Introduce minimal cryptography library

From: Andy Lutomirski
Date: Thu Aug 09 2018 - 14:08:51 EST


On Tue, Aug 7, 2018 at 6:51 PM, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> On Tue, Aug 7, 2018 at 6:49 PM Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
>> I really wish we had a way to see that we use asm-genericâs copy of a header in all cases except where an arch opts out.
>
> It's really not that hard to do -- symlink asm-generic to a target
> called "asm" inside an otherwise empty directory, and add that
> otherwise empty directory to the -I paths just after arch/include.
> Since it's searched second, it's only used if the first fails. Maybe
> I'm missing something though, as this seems a bit too obvious. Perhaps
> a project for another day.

The problem here (I think) is that it's preferable for stray files in
the kernel tree to have no effect and, with this scheme, stray files
in arch/*/include/asm could affect the build. So something explicit
has an advantage. I just think there should be way to say "this
asm-generic file should affect all arches unless they generic-n or
override-generic-y it or whatever".