Re: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric

From: Julius Werner
Date: Thu Aug 09 2018 - 14:10:59 EST


> @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void __iomem *ptr)
> ptr_entry += entry.size;
> }
>
> - if (ret)
> + if (ret) {
> + bus_unregister(&coreboot_bus_type);
> iounmap(ptr);
> + }

nit: maybe cleaner to just do if (ret) coreboot_table_exit(); here?
You're essentially writing the same code again.