Re: [PATCH net-next 1/9] net: hns3: Add support for serdes loopback selftest

From: David Miller
Date: Mon Aug 13 2018 - 11:55:01 EST


From: Salil Mehta <salil.mehta@xxxxxxxxxx>
Date: Sun, 12 Aug 2018 10:47:30 +0100

> -#define HNS3_SELF_TEST_TPYE_NUM 1
> +#define HNS3_SELF_TEST_TPYE_NUM 2

Is this supposed to be the number of self test "types"? If so, this CPP
macro should be named "HNS3_SELF_TEST_TYPE_NUM".

> +
> + count ++;
^

Please remove that unnecessary space.

> + } while (++i < HCLGE_SERDES_RETRY_NUM &&
^^

Only need one space there, not two.