Re: [PATCH] net: systemport: fix unused function warning

From: Florian Fainelli
Date: Tue Aug 14 2018 - 09:26:51 EST


On 08/13/2018 03:10 PM, Arnd Bergmann wrote:
> The only remaining caller of this function is inside of an #ifdef
> after another caller got removed. This causes a harmless warning
> in some configurations:
>
> drivers/net/ethernet/broadcom/bcmsysport.c:1068:13: error: 'bcm_sysport_resume_from_wol' defined but not used [-Werror=unused-function]
>
> Removing the #ifdef around the PM functions simplifies the code
> and avoids the problem but letting the compiler drop the unused
> functions silently.
>
> Fixes: 9e85e22713d6 ("net: systemport: Do not re-configure upon WoL interrupt")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Thank you Arnd.
--
Florian