Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled

[Christian KÃnig]

Am 14.08.2018 um 11:15 schrieb Arnd Bergmann:
> On Tue, Aug 14, 2018 at 10:54 AM Michel DÃnzer <michel@xxxxxxxxxxx> wrote:
> > On 2018-08-13 05:23 PM, Arnd Bergmann wrote:
> > > On Mon, Aug 13, 2018 at 4:49 PM Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
> > > > On Sun, Aug 12, 2018 at 3:55 AM Christian KÃnig
> > > > <ckoenig.leichtzumerken@xxxxxxxxx> wrote:
> > > > > Adding Harry as well.
> > > > > Am 11.08.2018 um 17:54 schrieb Arnd Bergmann:
> > > > > > Fixes: bf2e2e2e0ea9 ("drm/amd/display: Limit DCN to x86 arch")
> > > > > > Fixes: 4841203102a3 ("drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86")
> > > > Maybe it would be better to revert 4841203102a3 so we can limit the
> > > > scope of this to DCN support.
> > > That would help, but we would still require the patch at
> > > https://patchwork.kernel.org/patch/10090227/ or something else to avoid
> > > broken randconfig builds.
> > FWIW, please don't revert 4841203102a3 in a way which allows
> > CONFIG_DRM_AMD_DC_DCN1_0 to be accidentally disabled on X86 again. If it
> > is reinstated, it should be strictly derived from other options, not
> > changeable by the user.
> How about making all of AMDGPU depend on
> " !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS) || BROKEN"
> then?

Well, certainly not a good idea.

We don't want to disable the whole driver just because one broken component.

Christian.

>       Arnd