RE: [PATCH net-next 1/9] net: hns3: Add support for serdes loopback selftest

[Salil Mehta]

Hi Dave,

> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Monday, August 13, 2018 4:55 PM
> To: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@xxxxxxxxxx>; lipeng (Y)
> <lipeng321@xxxxxxxxxx>; mehta.salil.lnk@xxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Linuxarm
> <linuxarm@xxxxxxxxxx>; linyunsheng <linyunsheng@xxxxxxxxxx>
> Subject: Re: [PATCH net-next 1/9] net: hns3: Add support for serdes
> loopback selftest
> 
> From: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Date: Sun, 12 Aug 2018 10:47:30 +0100
> 
> > -#define HNS3_SELF_TEST_TPYE_NUM		1
> > +#define HNS3_SELF_TEST_TPYE_NUM		2

Sure, fixed in V2. Thanks.

> 
> Is this supposed to be the number of self test "types"?  If so, this
> CPP
> macro should be named "HNS3_SELF_TEST_TYPE_NUM".
> 
> > +
> > +		count ++;
>                      ^
> 
> Please remove that unnecessary space


Sure, fixed in V2 version, thanks.


> 
> > +	} while (++i < HCLGE_SERDES_RETRY_NUM  &&
>                                              ^^
> 
> Only need one space there, not two.

Thank you. Fixed in V2.

Best regards
Salil