Re: [PATCH 1/2] dt-bindings: clk: meson-g12a: Add G12A AO Clock Bindings

[Jian Hu]

On 2018/8/15 4:48, Rob Herring wrote:
> On Fri, Aug 10, 2018 at 05:54:27PM +0800, Jian Hu wrote:
> > Add new clock controller compatible and dt-bingdings headers
> > for the Always-On domain of the g12a SoC
> >
> > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/amlogic,gxbb-aoclkc.txt         |  1 +
> >   include/dt-bindings/clock/g12a-aoclkc.h            | 28 ++++++++++++++++++++++
> >   2 files changed, 29 insertions(+)
> >   create mode 100755 include/dt-bindings/clock/g12a-aoclkc.h
>
> checkpatch says wrong mode.
Yes, I have checked the g12a-aoclk.h file,It is wrong mode. I will chmod 
a-x for it.Thank you for review.
> > diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt
> > index 3a88052..6f02288 100644
> > --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt
> > +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt
> > @@ -10,6 +10,7 @@ Required Properties:
> >   	- GXL (S905X, S905D) : "amlogic,meson-gxl-aoclkc"
> >   	- GXM (S912) : "amlogic,meson-gxm-aoclkc"
> >   	- AXG (A113D, A113X) : "amlogic,meson-axg-aoclkc"
> > +	- G12A (S905D2, S905X2) : "amlogic,g12a-aoclkc"
> >   	followed by the common "amlogic,meson-gx-aoclkc"
> >   
> >   - #clock-cells: should be 1.
> > diff --git a/include/dt-bindings/clock/g12a-aoclkc.h b/include/dt-bindings/clock/g12a-aoclkc.h
> > new file mode 100755
> > index 0000000..6b3f921
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/g12a-aoclkc.h
> > @@ -0,0 +1,28 @@
> > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> > +/*
> > + * Copyright (c) 2016 BayLibre, SAS
> > + * Author: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> > + *
> > + * Copyright (c) 2018 Amlogic, inc.
> > + * Author: Jian Hu<jian.hu@xxxxxxxxxxx>
> > + */
> > +
> > +#ifndef DT_BINDINGS_CLOCK_AMLOGIC_MESON_G12A_AOCLK
> > +#define DT_BINDINGS_CLOCK_AMLOGIC_MESON_G12A_AOCLK
> > +
> > +#define CLKID_AO_AHB_BUS		0
> > +#define CLKID_AO_REMOTE			1
> > +#define CLKID_AO_I2C_MASTER		2
> > +#define CLKID_AO_I2C_SLAVE		3
> > +#define CLKID_AO_UART1			4
> > +#define CLKID_AO_PROD_I2C		5
> > +#define CLKID_AO_UART2			6
> > +#define CLKID_AO_IR_BLASTER		7
> > +#define CLKID_AO_SAR_ADC		8
> > +#define CLKID_AO_CLK81			9
> > +#define CLKID_AO_SAR_ADC_SEL		10
> > +#define CLKID_AO_SAR_ADC_DIV		11
> > +#define CLKID_AO_SAR_ADC_CLK		12
> > +#define CLKID_AO_ALT_XTAL		13
> > +
> > +#endif
> > --
> > 1.9.1
>
> .