Re: [PATCH 2/2] Replace magic for trusting the secondary keyring with #define

From: kbuild test robot
Date: Wed Aug 15 2018 - 17:20:38 EST


Hi Yannik,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18 next-20180814]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Yannik-Sembritzki/Fix-kexec-forbidding-kernels-signed-with-keys-in-the-secondary-keyring-to-boot/20180816-042529
config: x86_64-randconfig-x019-201832 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

In file included from include/keys/asymmetric-type.h:18:0,
from crypto/asymmetric_keys/asymmetric_keys.h:12,
from crypto/asymmetric_keys/restrict.c:17:
>> include/linux/verification.h:12:0: error: unterminated #ifndef
#ifndef _LINUX_VERIFICATION_H

--
In file included from include/crypto/pkcs7.h:15:0,
from crypto/asymmetric_keys/pkcs7_parser.h:13,
from crypto/asymmetric_keys/pkcs7_parser.c:20:
>> include/linux/verification.h:12:0: error: unterminated #ifndef
#ifndef _LINUX_VERIFICATION_H

In file included from include/keys/asymmetric-type.h:18:0,
from crypto/asymmetric_keys/x509_parser.h:14,
from crypto/asymmetric_keys/pkcs7_parser.h:14,
from crypto/asymmetric_keys/pkcs7_parser.c:20:
>> include/linux/verification.h:12:0: error: unterminated #ifndef
#ifndef _LINUX_VERIFICATION_H


vim +12 include/linux/verification.h

e68503bd David Howells 2016-04-06 @12 #ifndef _LINUX_VERIFICATION_H
e68503bd David Howells 2016-04-06 13 #define _LINUX_VERIFICATION_H
e68503bd David Howells 2016-04-06 14

:::::: The code at line 12 was first introduced by commit
:::::: e68503bd6836ba765dc8e0ee77ea675fedc07e41 KEYS: Generalise system_verify_data() to provide access to internal content

:::::: TO: David Howells <dhowells@xxxxxxxxxx>
:::::: CC: David Howells <dhowells@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip