Re: [PATCH v9 18/22] s390: vfio-ap: implement VFIO_DEVICE_RESET ioctl
From: Cornelia Huck
Date: Fri Aug 17 2018 - 05:38:42 EST
On Wed, 15 Aug 2018 17:05:48 -0400
Tony Krowiak <akrowiak@xxxxxxxxxxxxx> wrote:
> On 08/15/2018 12:38 PM, Cornelia Huck wrote:
> > On Mon, 13 Aug 2018 17:48:15 -0400
> > Tony Krowiak <akrowiak@xxxxxxxxxxxxxxxxxx> wrote:
> >> + case VFIO_DEVICE_RESET:
> >> + ret = vfio_ap_mdev_reset_queues(mdev, true);
> > If I see it correctly, you call this function only ever with force ==
> > true (here and in the previous patch). Is that what you intended?
> That does seem to be the case now; however, I think at one time there were
> additional calls to this function. For some reason of which I am not aware,
> those were removed, so there is probably no need for it now.
If you don't see a need for it anymore, I'd just remove the parameter.
Even makes vfio_ap_mdev_reset_queues() a bit nicer :)