Re: [PATCH 1/1] perf/x86/intel: make error messages less confusing
From: Andi Kleen
Date: Tue Aug 21 2018 - 18:09:41 EST
On Tue, Aug 21, 2018 at 02:15:28PM -0700, Eduardo Valentin wrote:
> On a system with X86_FEATURE_ARCH_PERFMON disabled
> and with a model not known by family PMU drivers,
> user gets a kernel message log like the following:
> [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver, software events only.
> The "unsupported .. CPU" part may be confusing for some
> users. Rewording the messages on the failure path to:
> [ 0.667154] Performance Events: unknown p6 PMU on CPU model 85: !X86_FEATURE_ARCH_PERFMON: no PMU driver, software events only.
Are you sure users even know what ARCH_PERFMON is?
Maybe it is confusing (why exactly?), but it doesn't seem to me that your
new message is any better.
If you refer to VMs not exposing the PMU perhaps that should be explicitely mentioned.
Of course the real fix is to always expose the PMU, not improve the error messages...