Re: [PATCH] mt76: Fix comparisons with invalid hardware key index
From: Stanislaw Gruszka
Date: Fri Aug 24 2018 - 04:08:26 EST
On Thu, Aug 23, 2018 at 11:27:38PM +0200, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c: In function âmt76x0_txâ:
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:169: warning: comparison is always true due to limited range of data type
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c: In function âmt76x2_txâ:
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c:35: warning: comparison is always true due to limited range of data type
> While assigning -1 to a u8 works fine, comparing with -1 does not work
> as expected.
> Fix this by comparing with 0xff, like is already done in some other
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Ack for mt76x0. I think Lorenzo already posted patch for mt76x2.