RE: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support

From: Fabrizio Castro
Date: Fri Aug 24 2018 - 04:31:50 EST

Hello Simon,

Thank you for the feedback!

> >
> > In theory CAN could be broken if renesas,can-clock-select is set to 0x1
> > (clkp2) in the DT, as this value will be written to the CAN Clock Select
> > Register. However if the documentation is followed there will be no
> > problems.
> >
> > We should probably update the driver to fix this though, which will be a
> > change specific to all RZ/G2 devices, so perhaps we should also be adding
> > a "renesas,rzg-gen2-can" family compatible string as well? (to driver and
> > documentation)
> Yes, I think that sounds reasonable.
> But in that case we should pre-emptively not use renesas,rcar-gen3-can for
> RZ/G2.

What do you think about the following:


Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.