Re: [PATCH 1/4] iio: gyro: add support for fxas21002c
From: Joe Perches
Date: Mon Aug 27 2018 - 16:50:16 EST
On Mon, 2018-08-27 at 18:08 +0100, Jonathan Cameron wrote:
> On Sat, 25 Aug 2018 22:19:07 +0100
> Afonso Bordado <afonsobordado@xxxxxx> wrote:
> > FXAS21002C is a 3 axis gyroscope with integrated temperature sensor
> > Signed-off-by: Afonso Bordado <afonsobordado@xxxxxx>
> Driver is pretty clean so only a few minor comments inline.
> If we were late in a cycle I'd probably just have taken it and fixed up
> but as we have lots of time and I'm inherently lazy I'll let you do a v2 :)
> Good job, thanks!
> > diff --git a/drivers/iio/gyro/fxas21002c.c b/drivers/iio/gyro/fxas21002c.c
> /* ... */
> Please run checkpatch as IIRC it complains about this.
Running checkpatch and paying attention to what it bleats
is generally a good idea, as long as its bleats aren't
And c99 style // comments have been ignored since:
Author: Joe Perches <joe@xxxxxxxxxxx>
Date: Tue Aug 2 14:04:33 2016 -0700
checkpatch: allow c99 style // comments
Sanitise the lines that contain c99 comments so that the error doesn't