Re: [RESEND] PCI: imx: Initial imx7d pm support
From: Leonard Crestez
Date: Tue Aug 28 2018 - 09:00:22 EST
On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote:
> On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote:
> > On imx7d the pcie-phy power domain is turned off in suspend and this can
> > make the system hang after resume when attempting any read from PCI.
> > Fix this by adding minimal suspend/resume code from the nxp internal
> > tree. This will prepare for powering down on suspend and reset the block
> > on resume.
> > Code is only for imx7d but a very similar sequence can be used for
> > other socs.
> > The original author is mostly Richard Zhu <hongxing.zhu@xxxxxxx>, this
> > patch adjusts the code to the upstream imx7d implemention using reset
> > controls and power domains.
> I will add a Suggested-by: replacing this paragraph, it is always better
> to add proper tags rather than credit hidden in commit logs messages.
Isn't "Originally-by:" a better tag for this?
> > Some dependencies in this area are complicated but as far as I know
> > including this patch without others should not break anything that was
> > not already broken. Since this is a patch for something that has never
> > worked before it should be treated as a feature not a bugfix.
> Ok, so I consider this v4.20 material, please shout if it has to be
> sent as a fix, I do not think so given what we discussed above.