Re: [PATCH v6 4/4] venus: firmware: register separate platform_device for firmware loader

From: Rob Herring
Date: Tue Aug 28 2018 - 18:15:19 EST


On Thu, Aug 23, 2018 at 07:58:48PM +0530, Vikash Garodia wrote:
> From: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
>
> This registers a firmware platform_device and associate it with
> video-firmware DT subnode. Then calls dma configure to initialize
> dma and iommu.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
> ---
> .../devicetree/bindings/media/qcom,venus.txt | 13 +++++-

In the future, please split binding patches.

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/media/platform/qcom/venus/core.c | 14 +++++--
> drivers/media/platform/qcom/venus/firmware.c | 49 ++++++++++++++++++++++
> drivers/media/platform/qcom/venus/firmware.h | 2 +
> 4 files changed, 73 insertions(+), 5 deletions(-)