Re: [PATCH v2 7/9] net: stmmac: dwmac-sun8i: fix OF child-node lookup
From: Johan Hovold
Date: Wed Aug 29 2018 - 03:54:35 EST
On Tue, Aug 28, 2018 at 10:06:24AM +0200, Corentin Labbe wrote:
> On Mon, Aug 27, 2018 at 10:21:51AM +0200, Johan Hovold wrote:
> > Use the new of_get_compatible_child() helper to lookup the mdio-internal
> > child node instead of using of_find_compatible_node(), which searches
> > the entire tree from a given start node and thus can return an unrelated
> > (i.e. non-child) node.
> > This also addresses a potential use-after-free (e.g. after probe
> > deferral) as the tree-wide helper drops a reference to its first
> > argument (i.e. the mdio-mux node). Fortunately, this was inadvertently
> > balanced by a failure to drop the mdio-mux reference after lookup.
> > While at it, also fix the related mdio-internal- and phy-node reference
> > leaks.
> > Fixes: 634db83b8265 ("net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs")
> > Cc: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> > Cc: Andrew Lunn <andrew@xxxxxxx>
> > Cc: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
> > Cc: Alexandre Torgue <alexandre.torgue@xxxxxx>
> > Cc: Jose Abreu <joabreu@xxxxxxxxxxxx>
> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> You should have CCed sunxi maintainers
> Maxime Ripard <maxime.ripard@xxxxxxxxxxx> (maintainer:ARM/Allwinner sunXi SoC support)
> Chen-Yu Tsai <wens@xxxxxxxx> (maintainer:ARM/Allwinner sunXi SoC support)
Yeah, I cut down the CC list somewhat (I think because they didn't seem
to be actively involved in the stmmac patch handling). Thanks for adding
> Since I am just back from holidays, I will test this patch this week.
Thanks, that would be great.