Re: [PATCH v3 6/6] mmc: tmio: refactor CLK_CTL bit calculation

[Ulf Hansson]

On 29 August 2018 at 10:49, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>
>> +     if (divisor <= 1) {
>> +             clk_sel = 1;
>> +             clk = 0;
>> +     } else {
>> +             clk_sel = 0;
>> +             /* bit7 set: 1/512, ... bit0 set:1/4, all bits clear: 1/2 */
>> +             clk = roundup_pow_of_two(divisor) >> 2;
>> +     }
>
> What about
>
>         clk_sel = (divisor <= 1);
>         clk = clk_sel ? 0 : (roundup_pow_of_two(divisor) >> 2)
>
> More concise, but I think still readable. I don't mind super much,
> though.

Right. So, may I apply Yamada-san's original patch (adding your
tested/reviewed-by tag) and the above as a code-cleanup for you to
address on top?

Kind regards
Uffe