Re: [PATCH v9 4/4] perf probe: Support SDT markers having reference counter (semaphore)

From: Arnaldo Carvalho de Melo
Date: Thu Aug 30 2018 - 14:50:37 EST


Em Thu, Aug 30, 2018 at 02:45:31PM -0400, Steven Rostedt escreveu:
>
> Arnaldo,
>
> I'm going to be playing with some of the probe code which may conflict
> with these patches, so I would like to pull these in my tree. But this
> patch requires an Acked-by from you before I can pull it in.
>
> You OK with this?

Acked-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

> Thanks!
>
> -- Steve
>
>
> On Mon, 20 Aug 2018 10:12:50 +0530
> Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx> wrote:
>
> > With this, perf buildid-cache will save SDT markers with reference
> > counter in probe cache. Perf probe will be able to probe markers
> > having reference counter. Ex,
> >
> > # readelf -n /tmp/tick | grep -A1 loop2
> > Name: loop2
> > ... Semaphore: 0x0000000010020036
> >
> > # ./perf buildid-cache --add /tmp/tick
> > # ./perf probe sdt_tick:loop2
> > # ./perf stat -e sdt_tick:loop2 /tmp/tick
> > hi: 0
> > hi: 1
> > hi: 2
> > ^C
> > Performance counter stats for '/tmp/tick':
> > 3 sdt_tick:loop2
> > 2.561851452 seconds time elapsed
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
> > Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>