Re: [PATCH v3 01/30] mfd: Makefile: Remove build option for MFD:sun4i-gpadc
From: Maxime Ripard
Date: Fri Aug 31 2018 - 04:26:00 EST
First, thanks for doing that rework. It was needed, and it's very much
As you can imagine though, I have a bunch of comments.
On Thu, Aug 30, 2018 at 05:44:49PM +0200, Philipp Rossak wrote:
> Since we are merging the mfd driver into the sun4i-gpadc driver we need
> to remove the build options for the sun4i-gpadc driver.
> Signed-off-by: Philipp Rossak <embed3d@xxxxxxxxx>
> drivers/mfd/Makefile | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index e9fd20dba18d..c680994db988 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -220,7 +220,6 @@ obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o
> obj-$(CONFIG_MFD_MT6397) += mt6397-core.o
> obj-$(CONFIG_MFD_ALTERA_A10SR) += altera-a10sr.o
> -obj-$(CONFIG_MFD_SUN4I_GPADC) += sun4i-gpadc.o
One of the things we should strive for is bisectability, which means
being able to have a working driver at every point in time while
introducing the features.
In this particular case, this isn't really a problem since you're
removing part of code that were never really enabled, but you should
at least document why in your commit log.
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
Description: PGP signature