Re: [PATCH net-next v3 02/10] net: mvpp2: phylink support
From: Andrew Lunn
Date: Fri Aug 31 2018 - 10:37:31 EST
> Can you see any down-sides to moving the netif_carrier_off() in
> mvneta_open() to phylink_start() ?
This sounds like a good idea.
What happens on the resume path?
I've not looked at any code.... Just thinking aloud. Can we suspend
with the link up? When we resume, so long as we were not doing WoL,
the link is down. If phylink_start() is not called, we have this miss
And what about the WoL case? The link is up. What happens if you do a
netif_carrier_off() in phylink_start(), you again have a miss match.
But that case is pretty common with us developers, tftpbooting the
box, with uboot setting the link up before handing over the Linux. So
that case probably works already.