Re: [PATCH 1/3] dt-bindings: change the A64 HDMI PHY binding to R40

From: Maxime Ripard
Date: Wed Sep 05 2018 - 03:14:40 EST


On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote:
> By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux
> introduced in R40, although it has two PLL-VIDEOs.
>
> Change the A64 HDMI PHY binding to R40 one.
>
> This binding is introduced in v4.19, which is still in RC stage, so we
> have change to fix it.
>
> Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>

That doesn't make much sense. The A64 doesn't have any particular
reason to behave like the R40, and the R40 can definitely use a
different compatible if it has a different behaviour. But I don't see
*why* the A64 not behaving like the R40 is a justification to remove
the A64 compatible. Especially when the R40 was released later.

Add a new compatible, and leave the A64 compatible alone.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature