Re: [PATCH 03/11] UAPI: virtio_net: Fix use of C++ keywords as structural members

From: David Howells
Date: Wed Sep 05 2018 - 13:15:10 EST


Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> Come on now, either put the whole C namespace stuff around the file,

You mean wrap it with 'extern "C" { ... }'? That doesn't fix it. That only
affects the symbols generated by the compiler.

> "class" is a fine variable name for C code, there's no reason this has
> to change here at all.

I'm trying to prevent future accidents like the one in linux/keyctl.h. The
easiest way to do this[**] is to pass the entire set of UAPI headers[*]
through the compiler together.

Besides I still have my dark plan to C++-ise the kernel[***] :-D

David

[*] with some obvious exceptions

[**] and it catches other errors too

[***] https://lkml.org/lkml/2018/4/1/116