Re: [PATCH 05/11] UAPI: coda: Don't use internal kernel structs in UAPI

From: David Howells
Date: Thu Sep 06 2018 - 03:13:58 EST


Yann Droneaud <ydroneaud@xxxxxxxxxx> wrote:

> This structure should not have been exposed to userspace in the first
> place: it's unusable by userspace as it is. It was incorrect to have it
> outside of #ifdef __KERNEL__ before commit 607ca46e97a1b ...
> ...
> All CODA_REQ_* defines internals to kernel side and not exchanged with
> userspace.
>
> Please move them back to <linux/coda_psdev.h>

Is there any reason coda_psdev.h needs to be in include/linux/ rather than
fs/coda/?

David