Re: [f2fs-dev] [PATCH] f2fs: submit bio after shutdown

From: Chao Yu
Date: Mon Sep 10 2018 - 10:15:53 EST


On 2018/9/8 5:28, Jaegeuk Kim wrote:
> Sometimes, some merged IOs could get a chance to be submitted, resulting in
> system hang in shutdown test. This issues IOs all the time after shutdown.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,

> ---
> fs/f2fs/data.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 8c204f896c22..26f38b224bb2 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -533,6 +533,8 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
> if (fio->in_list)
> goto next;
> out:
> + if (is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN))
> + __submit_merged_bio(io);
> up_write(&io->io_rwsem);
> }
>
>