Re: [PATCH v2 3/5] irqchip: RISC-V Local Interrupt Controller Driver

From: Christoph Hellwig
Date: Tue Sep 11 2018 - 02:23:01 EST


On Tue, Sep 11, 2018 at 09:27:45AM +0530, Anup Patel wrote:
> The list of currently defined RISC-V local interrupts will definitely grow
> based on my experience from ARM/ARM64 world.
>
> Like Thomas mentioned, we will definitely end-up having separate
> irqchip and irq_domain for RISC-V local interrupts for flexibility. Better
> do it now with separate RISC-V INTC driver.

I disagree. Just because arm made a mess of their irq handling there
is no need to repeat mistakes by paving their way. IFF we end up
with a convoluted mess like arm in the end we'll need an irqchip,
and as your series has shown that is fairly easily doable. But I'd
rather spend my effort on it not becoming a mess in the first place
rather than helping the mess.