Re: [PATCH 4.4 34/80] enic: handle mtu change for vf properly

From: Ben Hutchings
Date: Tue Sep 11 2018 - 21:03:20 EST


On Mon, 2018-09-03 at 18:49 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
>
> ------------------
>
> From: Govindarajulu Varadarajan <gvaradar@xxxxxxxxx>
>
> [ Upstream commit ab123fe071c9aa9680ecd62eb080eb26cff4892c ]
>
> When driver gets notification for mtu change, driver does not handle it for
> all RQs. It handles only RQ[0].
>
> Fix is to use enic_change_mtu() interface to change mtu for vf.
[...]

This causes a assertion failure (noisy error logging, but not an oops)
when the driver is probed. This was fixed upstream by:

commit cb5c6568867325f9905e80c96531d963bec8e5ea
Author: Govindarajulu Varadarajan <gvaradar@xxxxxxxxx>
Date:ÂÂÂMon Jul 30 09:56:54 2018 -0700

ÂÂÂÂenic: do not call enic_change_mtu in enic_probe

which is now needed on the 3.18, 4.4, and 4.9 stable branches.

Ben.

--
Ben Hutchings, Software Developer  Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom