Re: [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations
From: Arnd Bergmann
Date: Wed Sep 12 2018 - 12:25:36 EST
On Wed, Sep 12, 2018 at 6:10 PM David Laight <David.Laight@xxxxxxxxxx> wrote:
> From: Arnd Bergmann
> > Sent: 12 September 2018 16:01
> > The ceph_ioctl function is used both for files and directories, but only
> > the files support doing that in 32-bit compat mode.
> > For consistency, add the same compat handler to the dir operations
> > as well.
> Have you verified that all the relevant ioctl buffer structures are
> exactly the same for 32bit and 64bit applications?
I checked it now, it's fine: there are only ceph_ioctl_dataloc
and ceph_ioctl_layout structures passed here, both of which
I assumed that the ceph_dir_fops operations were correct
here (they are), but you are right that I should have double
checked for more bugs as I encountered one of them.