Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers

From: Greg Kroah-Hartman
Date: Wed Sep 12 2018 - 14:13:16 EST


On Wed, Sep 12, 2018 at 05:01:04PM +0200, Arnd Bergmann wrote:
> A handful of drivers all have a trivial wrapper around their ioctl
> handler, but don't call the compat_ptr() conversion function at the
> moment. In practice this does not matter, since none of them are used
> on the s390 architecture and for all other architectures, compat_ptr()
> does not do anything, but using the new generic_compat_ioctl_ptrarg
> helper makes it more correct in theory, and simplifies the code.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/misc/cxl/flash.c | 8 +-------
> drivers/misc/genwqe/card_dev.c | 23 +----------------------
> drivers/scsi/megaraid/megaraid_mm.c | 28 +---------------------------
> drivers/usb/gadget/function/f_fs.c | 12 +-----------
> 4 files changed, 4 insertions(+), 67 deletions(-)

Nice cleanup on this series!

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>