Re: [PATCH 3/6] selinux: convert to kvmalloc

From: Paul Moore
Date: Wed Sep 12 2018 - 22:27:58 EST


On Fri, Sep 7, 2018 at 1:50 PM Kent Overstreet
<kent.overstreet@xxxxxxxxx> wrote:
> On Sat, Sep 08, 2018 at 02:08:03AM +0900, Tetsuo Handa wrote:
> > On 2018/09/08 1:56, Kent Overstreet wrote:
> > > @@ -329,8 +328,7 @@ int avtab_alloc(struct avtab *h, u32 nrules)
> > > nslot = MAX_AVTAB_HASH_BUCKETS;
> > > mask = nslot - 1;
> > >
> > > - h->htable = flex_array_alloc(sizeof(struct avtab_node *), nslot,
> > > - GFP_KERNEL | __GFP_ZERO);
> > > + h->htable = kvmalloc_array(nslot, sizeof(void *), GFP_KERNEL);
> > > if (!h->htable)
> > > return -ENOMEM;
> > >
> >
> > kvmalloc_array() does not imply __GFP_ZERO.
>
> Thanks, fixed

When you resubmit this patch, please make sure you submit it to the
SELinux list (added to the To line above) so that it can be properly
reviewed and merged.

Thanks.

--
paul moore
www.paul-moore.com