Re: [PATCH v2 0/2] media: platform: Add Aspeed Video Engine Driver
From: Hans Verkuil
Date: Fri Sep 14 2018 - 13:15:07 EST
On 09/14/2018 05:08 PM, Eddie James wrote:
> On 09/14/2018 01:59 AM, Hans Verkuil wrote:
>> On 09/13/2018 09:29 PM, Eddie James wrote:
>>> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
>>> can capture and compress video data from digital or analog sources. With
>>> the Aspeed chip acting as a service processor, the Video Engine can
>>> capture the host processor graphics output.
>>> This series adds a V4L2 driver for the VE, providing a read() interface
>>> only. The driver triggers the hardware to capture the host graphics output
>>> and compress it to JPEG format.
>>> v4l2-compliance output:
>>> v4l2-compliance SHA : not available
>> There should be a SHA here. "not available" indicates that you didn't compile
>> from the git repository directly, and now I do not know how old this compliance
>> test is. Always compile from the latest git repo, never use a version from e.g.
>> a distro as they tend to be old and missing tests.
>> It would be great if you can do this and reply with the new compliance output.
> Hmm, I did compile from the latest git repo (maybe a week old now), but
> maybe our cross complication setup is preventing that hash from being
> generated. Will try and get it.
You can also just report the git commit hash if you can't get it to work.
As long as I know from which source version it was built.