Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match_data
From: Peter Rosin
Date: Sun Sep 16 2018 - 11:45:58 EST
On September 16, 2018 11:36:57 AM GMT+02:00, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>On Sat, 15 Sep 2018 13:35:06 +0200
>Peter Rosin <peda@xxxxxxxxxx> wrote:
>> On 2018-09-15 12:52, YueHaibing wrote:
>> > Drop call to of_match_device, which is subsumed by the subsequent
>> > call to of_device_get_match_data. The code becomes simpler, and a
>> > temporary variable can be dropped.
>> > Found by coccinelle.
>> > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> Acked-by: Peter Rosin <peda@xxxxxxxxxx>
>Similar change already in place from Julia Lawall back in May but
>looks like that just missed the last set for the merge window
>after I managed to loose it and only picked up again when Peter
>pointed it out in August.
>However, something odd is going on as these are not currently in
>Ah, looks line staging-next was updated 2 days ago and last linux-next
>is just before that.
Heh. I sure thought it looked familiar but assumed the old thing had hit next a long time ago and that this was something else...