Re: [PATCH v2 1/4] crypto: s5p-sss: Fix race in error handling

From: Kamil Konieczny
Date: Mon Sep 17 2018 - 11:47:34 EST




On 17.09.2018 17:09, Christoph Manszewski wrote:
> Remove a race condition introduced by error path in functions:
> s5p_aes_interrupt and s5p_aes_crypt_start. Setting the busy field of
> struct s5p_aes_dev to false made it possible for s5p_tasklet_cb to
> change the req field, before s5p_aes_complete was called.
>
> Change the first parameter of s5p_aes_complete to struct
> ablkcipher_request. Before spin_unlock, make a copy of the currently
> handled request, to ensure s5p_aes_complete function call with the
> correct request.
>
> Signed-off-by: Christoph Manszewski <c.manszewski@xxxxxxxxxxx>

Acked-by: Kamil Konieczny <k.konieczny@xxxxxxxxxxxxxxxxxxx>

Thanks!
Kamil

--
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland