[PATCH 4.18 018/158] cifs: connect to servername instead of IP for IPC$ share

From: Greg Kroah-Hartman
Date: Mon Sep 17 2018 - 19:07:31 EST


4.18-stable review patch. If anyone has any objections, please let me know.

------------------

From: Thomas Werschlein <thomas.werschlein@xxxxxxxxxx>

commit 395a2076b4064f97d3fce03af15210ff2a7bb7f9 upstream.

This patch is required allows access to a Microsoft fileserver failover
cluster behind a 1:1 NAT firewall.

The change also provides stronger context for authentication and share
connection (see MS-SMB2 3.3.5.7 and MS-SRVS 3.1.6.8) as noted by
Tom Talpey, and addresses comments about the buffer size for the UNC
made by AurÃlien Aptel.

Signed-off-by: Thomas Werschlein <thomas.werschlein@xxxxxxxxxx>
Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
CC: Tom Talpey <ttalpey@xxxxxxxxxxxxx>
Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx>
CC: Stable <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
fs/cifs/connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2523,7 +2523,7 @@ cifs_setup_ipc(struct cifs_ses *ses, str
if (tcon == NULL)
return -ENOMEM;

- snprintf(unc, sizeof(unc), "\\\\%s\\IPC$", ses->serverName);
+ snprintf(unc, sizeof(unc), "\\\\%s\\IPC$", ses->server->hostname);

/* cannot fail */
nls_codepage = load_nls_default();