RE: [PATCH] misc: remove redundant include moduleparam.h

From: Winkler, Tomas
Date: Tue Sep 18 2018 - 04:49:54 EST


> module.h already contains moduleparam.h, so it is safe to remove the
> redundant include.
>
> The issue is detected with the help of Coccinelle.
>
> eePlease enter the commit message for your changes. Lines starting
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> ---
> drivers/misc/mei/bus-fixup.c | 1 -
> drivers/misc/vmw_vmci/vmci_host.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index
> a6f41f9..80215c3 100644
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c

Ack.
Tomas

> @@ -17,7 +17,6 @@
> #include <linux/kernel.h>
> #include <linux/sched.h>
> #include <linux/module.h>
> -#include <linux/moduleparam.h>
> #include <linux/device.h>
> #include <linux/slab.h>
> #include <linux/uuid.h>
> diff --git a/drivers/misc/vmw_vmci/vmci_host.c
> b/drivers/misc/vmw_vmci/vmci_host.c
> index 83e0c95..be732e5 100644
> --- a/drivers/misc/vmw_vmci/vmci_host.c
> +++ b/drivers/misc/vmw_vmci/vmci_host.c
> @@ -15,7 +15,6 @@
>
> #include <linux/vmw_vmci_defs.h>
> #include <linux/vmw_vmci_api.h>
> -#include <linux/moduleparam.h>
> #include <linux/miscdevice.h>
> #include <linux/interrupt.h>
> #include <linux/highmem.h>
> --
> 1.7.12.4