Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

From: Greg Kroah-Hartman
Date: Tue Sep 18 2018 - 09:09:17 EST


On Tue, Sep 18, 2018 at 04:03:37PM +0300, Dan Carpenter wrote:
> On Tue, Sep 18, 2018 at 08:31:22PM +0800, Gao Xiang wrote:
> > (I have no clang environment to build kernel yet... :( I will try later, but I have no idea why it happens,
> > and it seems a false warning).
> >
> > Thanks,
> > Gao Xiang
> >
> > >
> > > Or is gcc just being "dumb" here? What about clang, have you tried
> > > building it with that compiler as well?
>
> Yeah. Gcc is wrong. Gcc used to be extra conservative and missed a
> bunch of bugs, but I guess now they're going in to opposite direction?
>
> Smatch gets this correct, but you have to rebuild the cross function DB
> twice to make the warning go away. It could be because it starts out
> with the old vle_get_logical_extent_head() information so it thinks it
> knows how that function works.

Ok, thanks for checking (both of you). Just initialize the variable to
keep gcc from printing foolish warnings.

thanks,

greg k-h