Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

From: Darren Hart
Date: Tue Sep 18 2018 - 13:51:18 EST

On Fri, Sep 14, 2018 at 09:57:48PM +0100, Al Viro wrote:
> On Fri, Sep 14, 2018 at 01:35:06PM -0700, Darren Hart wrote:
> > Acked-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx>
> >
> > As for a longer term solution, would it be possible to init fops in such
> > a way that the compat_ioctl call defaults to generic_compat_ioctl_ptrarg
> > so we don't have to duplicate this boilerplate for every ioctl fops
> > structure?
> Bad idea, that... Because several years down the road somebody will add
> an ioctl that takes an unsigned int for argument. Without so much as looking
> at your magical mystery macro being used to initialize file_operations.

Fair, being explicit in the declaration as it is currently may be
preferable then.

Darren Hart
VMware Open Source Technology Center