Re: [PATCH v4 8/8] trace: Add alternative synthetic event trace action syntax

From: Masami Hiramatsu
Date: Tue Sep 18 2018 - 14:54:49 EST


Hi Tom,

On Mon, 10 Sep 2018 14:10:46 -0500
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> From: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
>
> Add a 'trace(synthetic_event_name, params)' alternative to
> synthetic_event_name(params).
>
> Currently, the syntax used for generating synthetic events is to
> invoke synthetic_event_name(params) i.e. use the synthetic event name
> as a function call.
>
> Users requested a new form that more explicitly shows that the
> synthetic event is in effect being traced. In this version, a new
> 'trace()' keyword is used, and the synthetic event name is passed in
> as the first argument.

Hmm, what is the advantage of adding this new form?

Thanks,

--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>