Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

From: poza
Date: Tue Sep 18 2018 - 15:04:57 EST

On 2018-09-18 20:00, Sinan Kaya wrote:
On 9/18/2018 4:20 AM, Oza Pawandeep wrote:
+++ b/drivers/pci/pcie/err.c
@@ -265,6 +265,8 @@ static pci_ers_result_t broadcast_error_message(struct pci_dev *dev,
* The error is non fatal so the bus is ok; just invoke
* the callback for the function that logged the error.
+ if (cb == report_resume)
+ pci_cleanup_aer_uncorrect_error_status(dev);
cb(dev, &result_data);

In order to follow the existing behavior (drivers are calling
pci_cleanup_aer_uncorrect_error_status() right before return),
you should probably move the pci_cleanup_aer_uncorrect_error_status

cb(dev, &result_data);


some drivers are calling it in slot_reset, which is before resume,
while some are calling in beginning of resume (e.g. netxen_io_resume)

hence I have kept it before calling resume() (e.g. before cb(dev, &result_data))