Re: [PATCH v2 01/22] pinctrl: mediatek: add pinctrl-mtk-common-v2 for all MediaTek pinctrls

From: Linus Walleij
Date: Tue Sep 18 2018 - 15:36:35 EST

On Sat, Sep 8, 2018 at 4:07 AM <> wrote:

> From: Sean Wang <>
> Irregular register arrangement and distinct logic access from various
> MediaTek SoCs would cause pinctrl-mtk-common to bloat and really hard to
> maintain in the future so that the patch creates pinctrl-mtk-common-v2
> based on the core of mt7622-pinctrl.
> The goals pinctrl-mtk-common-v2 want to achieve are to hopefully support
> all of MediaTek SoCs, and two kinds of dt-bindings being supported,
> Linux generic pinctrl dt-binding mt7622 supports and MediaTek per-pin
> dt-binding the other SoCs support the MT8183 and MT6765 incline to make
> use of.
> The patch starts to refactor MT7622 pinctrl driver first with splitting
> out these portable ways from there such as table-based register operation
> and drive strength control that is common in both kinds of driver.
> Signed-off-by: Ryder.Lee <ryder.lee@xxxxxxxxxxxx>
> Signed-off-by: Sean Wang <>

Patch applied, had to use some fuzzing and removed a <linux/gpio.h>
include that was not used.

Linus Walleij