Re: [RFC][PATCH 01/11] asm-generic/tlb: Provide a comment

From: Peter Zijlstra
Date: Wed Sep 19 2018 - 07:33:16 EST


On Fri, Sep 14, 2018 at 05:48:57PM +0100, Will Deacon wrote:

> > + * - tlb_change_page_size()
>
> This doesn't seem to exist in my tree.
> [since realised you rename to it in the next patch]
>

> > + * Additionally there are a few opt-in features:
> > + *
> > + * HAVE_MMU_GATHER_PAGE_SIZE
> > + *
> > + * This ensures we call tlb_flush() every time tlb_change_page_size() actually
> > + * changes the size and provides mmu_gather::page_size to tlb_flush().
>
> Ah, you add this later in the series. I think Nick reckoned we could get rid
> of this (the page_size field) eventually...

Right; let me fix that ordering..