Re: [PATCH 5/6] staging: erofs: add some comments for xattr subsystem

From: Chao Yu
Date: Wed Sep 19 2018 - 11:27:42 EST


On 2018/9/19 13:49, Gao Xiang wrote:
> As Dan Carpenter pointed out, it is better to document what
> return values of these callbacks in `struct xattr_iter_handlers'
> mean and why it->ofs is increased regardless of success or
> failure in `xattr_foreach'.
>
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>
> ---

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,