Re: [PATCH] kgdboc: Fix warning with module build
From: Greg Kroah-Hartman
Date: Thu Sep 20 2018 - 03:16:59 EST
On Wed, Sep 19, 2018 at 06:59:01PM -0700, Laura Abbott wrote:
> After 2dd453168643 ("kgdboc: Fix restrict error"), kgdboc_option_setup is
> now only used when built in, resulting in a warning when compiled as a
> drivers/tty/serial/kgdboc.c:134:12: warning: 'kgdboc_option_setup' defined but not used [-Wunused-function]
> static int kgdboc_option_setup(char *opt)
> Move the function under the appropriate ifdef for builtin only.
> Fixes: 2dd453168643 ("kgdboc: Fix restrict error")
> Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx>
> drivers/tty/serial/kgdboc.c | 37 +++++++++++++++++++------------------
> 1 file changed, 19 insertions(+), 18 deletions(-)
You forgot a reported-by: tag :(
I'll go fix it up, thanks for the patch resolving this.