Re: [PATCH net-next v5 02/20] zinc: introduce minimal cryptography library
From: Jason A. Donenfeld
Date: Thu Sep 20 2018 - 20:18:02 EST
On Thu, Sep 20, 2018 at 5:42 PM Ard Biesheuvel
> Apologies for not spotting these before:
> > +ccflags-y := -O3
> -O3 optimization has been problematic in the past, at least on x86 but
> I think on other architectures as well. Please stick with -O2.
Fixed up for v6.
> > +ccflags-y += -Wframe-larger-than=$(if (CONFIG_KASAN),16384,8192)
> There is no way we can support code in the kernel with that kind of
> stack space requirements. I will let Arnd comment on what we typically
> allow, since he deals with such issues on a regular basis.
Also fixed up for v6 by just removing that line entirely.