Re: [PATCH] hwmon: remove redundant continue

From: zhong jiang
Date: Thu Sep 20 2018 - 21:38:25 EST


On 2018/9/21 1:30, Guenter Roeck wrote:
> On Thu, Sep 20, 2018 at 04:11:10PM +0800, zhong jiang wrote:
>> The continue will not truely skip any code. hence it is safe to
>> remove it.
>>
>> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> The proper subject line would be
>
> hwmon: (scpi-hwmon) <summary>
>
> Since it now happened several times that I got a patch without proper
> subject (ie where the subject does not even mention the affected driver),
> I am no longer going to accept patches if the affected driver is missing,
> sorry.
I will fix that and resend. Thanks

Sincerely,
zhong jiang
> Guenter
>
>> ---
>> drivers/hwmon/scpi-hwmon.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c
>> index 7e49da5..111d521 100644
>> --- a/drivers/hwmon/scpi-hwmon.c
>> +++ b/drivers/hwmon/scpi-hwmon.c
>> @@ -286,10 +286,8 @@ static int scpi_hwmon_probe(struct platform_device *pdev)
>> * any thermal zones or if the thermal subsystem is
>> * not configured.
>> */
>> - if (IS_ERR(z)) {
>> + if (IS_ERR(z))
>> devm_kfree(dev, zone);
>> - continue;
>> - }
>> }
>>
>> return 0;
>> --
>> 1.7.12.4
>>
>