Re: [PATCH] decnet: Remove unnecessary check for dev->name

From: Stephen Hemminger
Date: Fri Sep 21 2018 - 16:19:06 EST


On Fri, 21 Sep 2018 12:30:34 -0700
Nathan Chancellor <natechancellor@xxxxxxxxx> wrote:

> Clang warns that the address of a pointer will always evaluated as true
> in a boolean context.
>
> net/decnet/dn_dev.c:1366:10: warning: address of array 'dev->name' will
> always evaluate to 'true' [-Wpointer-bool-conversion]
> dev->name ? dev->name : "???",
> ~~~~~^~~~ ~
> 1 warning generated.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/116
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

Makes sense name in net_device is an array.

Reviewed-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>